Make sure, when plugins cause a GET request to fail, there is always a response body. #8643
Conversation
ywkaras
requested review from
SolidWallOfCode,
bryancall and
zwoop
as code owners
ywkaras
changed the title
ywkaras
force-pushed
the
403_post_remap
branch
2 times, most recently
from
f709eb8 to
093aff5
Compare
|
As an alternative to HttpMsgComp.h, Alan proposes https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/include/txn_box/ts_util.h / https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/src/ts_util.cc |
ywkaras
force-pushed
the
403_post_remap
branch
from
093aff5 to
5ed24f5
Compare
|
[approve ci centos] |
ywkaras
force-pushed
the
403_post_remap
branch
from
5ed24f5 to
c27c199
Compare
ywkaras
force-pushed
the
403_post_remap
branch
from
c27c199 to
5b26267
Compare
…response body. Adds Au test with plugin forcing various errors on various hooks, with default body or set body.
ywkaras
force-pushed
the
403_post_remap
branch
from
5b26267 to
4a70a82
Compare
| // | ||
| // This class and the base class are pseudo-namespaces, have only static member functions (no data members). | ||
| // The manager data cannot simply be in the base class, because the (static member) continuation function that | ||
| // runs on the TXN_CLOSE hook would not be able to access it. |
There was a problem hiding this comment.
This comment improvement is not directly related to this PR.
| #include <ts/experimental.h> | ||
| #include <tscore/ink_defs.h> | ||
| #include <tscpp/util/PostScript.h> | ||
| #include <tscpp/util/TextView.h> |
There was a problem hiding this comment.
Changed double quotes to braces to make it clear these are not subdirs under xdebug.
| #include <tscore/ink_defs.h> | ||
| #include <tscpp/util/PostScript.h> | ||
| #include <tscpp/util/TextView.h> | ||
| #include <tscpp/api/Cleanup.h> |
There was a problem hiding this comment.
No real change to xdebug, just from this header to make it available to all plugins.
| const char *reason = http_hdr_reason_lookup(s->http_return_code); | ||
| ; | ||
| build_response(s, &s->hdr_info.client_response, s->client_info.http_version, s->http_return_code, reason ? reason : "Error"); | ||
| build_error_response(s, s->http_return_code, reason ? reason : "Error", nullptr); |
There was a problem hiding this comment.
This is the only real code change. Most of this PR is to add an Au test.
|
Is this an incompatible change? Since plugin which may have generated empty response bodies in some cases will not generate non-empty response bodies? |
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
|
[approve ci autest] |
|
[approve ci autest] |
|
This was an ask from YCPI Prod. But, no point in fixing it if it's going to continue to rot in the Sun. |
4 participants
Adds Au test with plugin forcing various errors on various hooks, with default body
or set body.