-
Notifications
You must be signed in to change notification settings - Fork 845
traffic_ctl - Add rpc invoke option. #8695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
traffic_ctl - Add rpc invoke option. #8695
Conversation
Add Input option to invoke a rpc function by specifying the method name and the parameters directly from the command line.
|
[approve ci fedora] |
|
This #8694 will fix the autest |
|
[approve ci autest] |
| std::string id; //!< optional, only needed for method calls. | ||
| YAML::Node params; //!< This is defined by each remote API. | ||
|
|
||
| virtual std::string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang, shouldn't that be std::string const&?
|
Seems it would be nice to have a |
@SolidWallOfCode You can, the or thanks for the review |
apache#658) * traffic_ctl - Add rpc invoke option. (apache#8695) Add Input option to invoke a rpc function by specifying the method name and the parameters directly from the command line. (cherry picked from commit 20d2241) * MGMT - Improve invalid rpc param error description and some cleanup. (apache#8696) (cherry picked from commit 304ea26) * traffic_ctl - Run a clean up on the output style parameters making it easy to use. 'all,req,resp' are now grouped into the '--format rpc' option. (apache#8704) (cherry picked from commit 68e69e2) Co-authored-by: Damian Meden <damian.meden@gmail.com> Co-authored-by: Brian Neradt <brian.neradt@verizonmedia.com>
Add Input option to invoke a rpc function by specifying the method name and the parameters directly
from the command line.
With this change we now can call any rpc method without the need to support it in traffic_ctl:
This also removed
CustomizableRequestwhich is no longer needed(it was unused but left it as base for this case).