Skip to content

Conversation

@brbzull0
Copy link
Contributor

@brbzull0 brbzull0 commented Feb 25, 2022

Use better output format options to display traffic_ctl JSONRPC messages.
all,req,resp are now grouped into rpc.

$ traffic_ctl config get variable --format rpc
 --> {request}
 <-- {response}
 variable 123

@brbzull0 brbzull0 added the JSONRPC JSONRPC 2.0 related work. label Feb 25, 2022
@brbzull0 brbzull0 added this to the 10.0.0 milestone Feb 25, 2022
@brbzull0 brbzull0 requested a review from jrushford February 25, 2022 16:07
@brbzull0 brbzull0 requested a review from bryancall as a code owner February 25, 2022 16:07
@brbzull0 brbzull0 self-assigned this Feb 25, 2022
@brbzull0 brbzull0 modified the milestones: 10.0.0, 10-Dev Feb 28, 2022
@bryancall
Copy link
Contributor

We had a discussion in the weekly PR/issue review meeting and most people thought --output would mean sending it to a file. Leaving it as --format or --output-format might be better.

@brbzull0
Copy link
Contributor Author

brbzull0 commented Mar 1, 2022

We had a discussion in the weekly PR/issue review meeting and most people thought --output would mean sending it to a file. Leaving it as --format or --output-format might be better.

fair enough, will leave it as --format then!
Thanks!

@brbzull0 brbzull0 marked this pull request as draft March 1, 2022 16:47
@brbzull0 brbzull0 force-pushed the dmeden/traffic_ctl_tidy_up_output_format_selection branch 3 times, most recently from 5b14fbc to f047fc2 Compare March 2, 2022 12:26
… easy to use. 'all,req,resp' are now grouped into the '--format rpc' option.
@brbzull0 brbzull0 force-pushed the dmeden/traffic_ctl_tidy_up_output_format_selection branch from f047fc2 to ff79b07 Compare March 2, 2022 12:38
@brbzull0 brbzull0 marked this pull request as ready for review March 2, 2022 13:41
@brbzull0 brbzull0 changed the title traffic_ctl - Rename --format parameter to --output. traffic_ctl - Use better format output options. Mar 3, 2022
Copy link
Contributor

@jrushford jrushford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tests ok.

@brbzull0 brbzull0 merged commit 68e69e2 into apache:10-Dev Mar 4, 2022
@zwoop zwoop modified the milestones: 10-Dev, 10.0.0 Feb 2, 2023
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 19, 2023
apache#658)

* traffic_ctl - Add rpc invoke option. (apache#8695)

Add Input option to invoke a rpc function by specifying the method name and the parameters directly
from the command line.

(cherry picked from commit 20d2241)

* MGMT - Improve invalid rpc param error description and some cleanup. (apache#8696)

(cherry picked from commit 304ea26)

* traffic_ctl - Run a clean up on the output style parameters making it easy to use. 'all,req,resp' are now grouped into the '--format rpc' option. (apache#8704)

(cherry picked from commit 68e69e2)

Co-authored-by: Damian Meden <damian.meden@gmail.com>
Co-authored-by: Brian Neradt <brian.neradt@verizonmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JSONRPC JSONRPC 2.0 related work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants