Hostdb Restructure #8953
Merged
Hostdb Restructure #8953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default duration of time_since_epoch() is std::chrono::high_resolution_clock::duration, which will not generally be seconds. hostDB.refcountcache->put expects the epoch count to be a number of seconds. This explicitly casts to seconds so we get that expected value. This also makes some other std::chrono time updates. Co-authored-by: bneradt <bneradt@yahooinc.com>
* Debug_bw updates. And clang-format fix. * If HostDB returns only failed parents, try serving from cache. Before this change, the parent cache logic would give up if it couldn't resolve the origin name for a request. This will attempt to retrieve a cached response if the resolution fails.
bneradt
reviewed
Jul 13, 2022
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good to me. Yahoo is running with this internally, FWIW.
rob05c
approved these changes
Jul 13, 2022
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
LGTM. I don't see anything obviously concerning.
This is massive, I'm not sure it's possible for a human to really thoroughly review. But I don't think it can avoid being massive, and it needs done. And Yahoo running it in Prod adds considerable confidence.
fatih-acar
added a commit
to fatih-acar/trafficserver
that referenced
this pull request
Aug 24, 2022
HostDB restructure introduced a regression where DNS resolution for parent proxies would be skipped and the origin's address would be used instead. Fixes: apache#8953 Signed-off-by: Fatih Acar <facar@scaleway.com>
fatih-acar
added a commit
to fatih-acar/trafficserver
that referenced
this pull request
Aug 24, 2022
HostDB restructure introduced a regression where DNS resolution for parent proxies would be skipped and the origin's address would be used instead. Fixes: apache#8953 Signed-off-by: Fatih Acar <facar@scaleway.com>
Contributor
|
Changing the milestone to 10.0.0 from 10-Dev since this went into master. |
randall
pushed a commit
that referenced
this pull request
Sep 23, 2022
HostDB restructure introduced a regression where DNS resolution for parent proxies would be skipped and the origin's address would be used instead. Fixes: #8953 Signed-off-by: Fatih Acar <facar@scaleway.com> Co-authored-by: Fatih Acar <facar@scaleway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major restructuring of the HostDB internals, which should (externally) be backwards compatible. The original goal of this work was to provide better control of sending requests to down upstreams. That turned out to require rewriting the internal data structures to support atomic operations on shared state (otherwise it is not possible to have fine grained control of requests to the same upstream). Additional work was done to be in compliance with the long term L7 Routing strategy as defined by the L7 Working group.
This has been tested in production but more should be done.
The documentation needs a lot of work.
Originally #7874 but was closed by a branch accident.