Skip to content

Conversation

@bneradt
Copy link
Contributor

@bneradt bneradt commented Nov 7, 2022

We were putting servers that hit the per_server.connection.max limit on the dead server list if the client were connecting to them via HTTP CONNECT requests. This fixes the handling of these so the server is not put on the dead server list.

We were putting servers that hit the per_server.connection.max limit on
the dead server list if the client were connecting to them via HTTP
CONNECT requests. This fixes the handling of these so the server is not
put on the dead server list.
@bneradt bneradt added the HostDB label Nov 7, 2022
@bneradt bneradt added this to the 10.0.0 milestone Nov 7, 2022
@bneradt bneradt self-assigned this Nov 7, 2022
@bneradt
Copy link
Contributor Author

bneradt commented Nov 7, 2022

My branch testing shows that the issue this PR fixes was introduced via the hostdb restructure PR (#8953). Since that did not go into 9.2.x or earlier, this fix is only needed for master and 10-Dev and should not be cherry-picked elsewhere.

@SolidWallOfCode
Copy link
Member

I wonder if EUSERS should be propagated back and checked at a higher level, but that likely gets ugly.

@bneradt bneradt mentioned this pull request Nov 8, 2022
@bneradt bneradt merged commit a4f2f3d into apache:master Nov 8, 2022
@bneradt bneradt deleted the fix_per_server_connection_max_for_connect branch November 8, 2022 03:22
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Nov 15, 2022
We were putting servers that hit the per_server.connection.max limit on
the dead server list if the client were connecting to them via HTTP
CONNECT requests. This fixes the handling of these so the server is not
put on the dead server list.
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 19, 2023
We were putting servers that hit the per_server.connection.max limit on
the dead server list if the client were connecting to them via HTTP
CONNECT requests. This fixes the handling of these so the server is not
put on the dead server list.

(cherry picked from commit a4f2f3d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants