Add TsScalableSharedMutex.h: shared mutex minimizing thread memory cache contention. #9154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
force-pushed
the
TsScalableSharedMutex
branch
from
e586dfd to
111939f
Compare
Contributor
Author
|
I have to put this way on the back burner, as Yahoo is not prioritizing performance on hosts with a high core count. If anyone else wants to work on it, feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the performance test on an AMD EPYC 7742 64-Core Processor (128 logical cores). Performance was about 30 times faster with 256 threads (shared locking the mutex). However, performance was about 5 times slower with 16 threads.
If you compile this perf test with gcc version 8.3.1 , it will seg fault. It runs with gcc 9.2.1 and clang 10.0.0 .