Updated documentation and added test coverage for some caching behavior #9282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no-store and no-cache cache-control directives in request/response - authorization headers - cookie-related request/response
Contributor
|
[approve ci] |
bneradt
requested changes
Jan 3, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks great. I just have a few simple word-smithing suggestions for the docs.
Thanks for adding test coverage for these cases.
randall
reviewed
Jan 3, 2023
bneradt
requested changes
Jan 5, 2023
Make it clear that what ATS would ignore with ignore_client_no_cache and ignore_server_no_cache.
Contributor
|
Marking for 9.2.x since this is a helpful doc and test-only change. |
randall
approved these changes
Jan 6, 2023
zwoop
pushed a commit
that referenced
this pull request
Jan 10, 2023
* update documentation for certain cache behaviors * remove trailing whitespaces * reformated the doc * Fixed typo * Update doc for ignore_client_no_cache and ignore_server_no_cache Make it clear that what ATS would ignore with ignore_client_no_cache and ignore_server_no_cache. Co-authored-by: Zhengxi Li <zhengxi.li@yahooinc.com>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Documentation-only changes from apache#9282 for 9.2.x (apache#9291) Fix a crash from a server early abort (apache#9287) Skip dns_host_down autest from 9.2.x branch (apache#9286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5876 points out some mismatches between the documentation and the current behavior of ATS caching.
added coverage
Added AuTest coverage for caching behavior in the following areas to verify behavior:
documentation
The documentation is updated with the following changes:
Expiresormax-ageheaders to cacheno-cacheandno-storedirectivesAuthorizationheader from the list that ATS by default doesn't cache(since it's cached per testing)proxy.config.http.cache.ignore_authenticationis set to1, the response containing the header would be cachedpragmaandcache-controldirectives that ATS ignores when ignore_client_no_cache or ignore_server_no_cache is enabledAuTest failure
The newly added
ResponseCacheControlIgnoredTestis failing, indicating that there are some issues with theproxy.config.http.cache.ignore_server_no_cacheconfiguration. The test verifies that ATS ignores theno-cacheandno-storein responses when asked to do so.