Fix a crash from a server early abort #9287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
force-pushed
the
fix_server_early_abort_crash
branch
from
36e0235 to
c87cb3a
Compare
While adding test coverage around apache#9229, it was found that ATS will crash if the server both replies early to a request (i.e., starts replying before the body of the request is received), and then aborts early. This addresses that crash.
bneradt
force-pushed
the
fix_server_early_abort_crash
branch
from
c87cb3a to
dab7195
Compare
maskit
approved these changes
Jan 6, 2023
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Documentation-only changes from apache#9282 for 9.2.x (apache#9291) Fix a crash from a server early abort (apache#9287) Skip dns_host_down autest from 9.2.x branch (apache#9286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding test coverage around #9229, it was found that ATS will crash if the server both replies early to a request (i.e., starts replying before the body of the request is received), and then aborts early. This addresses that crash.
For Review
Unfortunately, github isn't recognizing that I renamed the test utility slow_post_client.py to slow_post_clients.py, and that I then re-purposed a new slow_post_client.py for this test. Thus: