Skip to content

Memory leaks with storing configuration filenames #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 2 commits into from
Jan 31, 2023
Merged

Memory leaks with storing configuration filenames #9324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f76b7
Memory leaks with storing configuration filenames
bryancall Jan 20, 2023
19e13ae
Don't reassign the ats_scoped_str
bryancall Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions mgmt/config/AddConfigFilesHere.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,9 @@ static constexpr bool NOT_REQUIRED{false};
void
registerFile(const char *configName, const char *defaultName, bool isRequired)
{
bool found = false;
const char *fname = REC_readString(configName, &found);
if (!found) {
fname = defaultName;
}
FileManager::instance().addFile(fname, configName, false, isRequired);
bool found = false;
ats_scoped_str fname(REC_readString(configName, &found));
FileManager::instance().addFile(found ? fname : defaultName, configName, false, isRequired);
}

//
Expand Down
1 change: 1 addition & 0 deletions mgmt/config/FileManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ FileManager::ConfigManager::ConfigManager(const char *fileName_, const char *con
FileManager::ConfigManager::~ConfigManager()
{
ats_free(fileName);
ats_free(configName);
}

//
Expand Down