Skip to content

Memory leaks with storing configuration filenames #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryancall merged 2 commits into from
Jan 31, 2023
Merged

Memory leaks with storing configuration filenames #9324

bryancall merged 2 commits into from
Jan 31, 2023

Conversation

@bryancall
Copy link
Contributor

@bryancall bryancall commented Jan 20, 2023 •
edited
Loading 

Direct leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x6651f7 in malloc (/opt/ats/bin/traffic_server+0x6651f7) (BuildId: 6cec0e60aa1fe241c1cb6927ced97cdd18bde355)
    #1 0x7fcfa46eb8a1 in ats_malloc /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/tscore/../../../src/tscore/ink_memory.cc:64:9
    #2 0x7fcfa46eb8a1 in _xstrdup /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/tscore/../../../src/tscore/ink_memory.cc:249:34
    #3 0xf150e2 in FileManager::ConfigManager::ConfigManager(char const*, char const*, bool, bool, FileManager::ConfigManager*) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/FileManager.cc:372:16
    #4 0xf0c1cb in FileManager::addFileHelper(char const*, char const*, bool, bool, FileManager::ConfigManager*) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/FileManager.cc:144:38
    #5 0xf0c1cb in FileManager::addFile(char const*, char const*, bool, bool, FileManager::ConfigManager*) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/FileManager.cc:134:3
    #6 0xf192f9 in registerFile(char const*, char const*, bool) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/AddConfigFilesHere.cc:47:27
    #7 0xf19475 in initializeRegistry() /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/AddConfigFilesHere.cc:71:3
    #8 0x76b43b in initialize_file_manager() /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/../../src/traffic_server/traffic_server.cc:698:3
    #9 0x76b43b in main /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/../../src/traffic_server/traffic_server.cc:1819:3
    #10 0x7fcfa364a50f in __libc_start_call_main (/lib64/libc.so.6+0x2750f) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136)

Direct leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x6651f7 in malloc (/opt/ats/bin/traffic_server+0x6651f7) (BuildId: 6cec0e60aa1fe241c1cb6927ced97cdd18bde355)
    #1 0x7fcfa46eb8a1 in ats_malloc /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/tscore/../../../src/tscore/ink_memory.cc:64:9
    #2 0x7fcfa46eb8a1 in _xstrdup /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/tscore/../../../src/tscore/ink_memory.cc:249:34
    #3 0xf150e2 in FileManager::ConfigManager::ConfigManager(char const*, char const*, bool, bool, FileManager::ConfigManager*) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/FileManager.cc:372:16
    #4 0xf0c1cb in FileManager::addFileHelper(char const*, char const*, bool, bool, FileManager::ConfigManager*) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/FileManager.cc:144:38
    #5 0xf0c1cb in FileManager::addFile(char const*, char const*, bool, bool, FileManager::ConfigManager*) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/FileManager.cc:134:3
    #6 0xf192f9 in registerFile(char const*, char const*, bool) /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/AddConfigFilesHere.cc:47:27
    #7 0xf19475 in initializeRegistry() /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/mgmt/config/../../../mgmt/config/AddConfigFilesHere.cc:71:3
    #8 0x76b43b in initialize_file_manager() /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/../../src/traffic_server/traffic_server.cc:698:3
    #9 0x76b43b in main /home/bcall/dev/apache/trafficserver/build-Linux_clang_h3_asan/src/../../src/traffic_server/traffic_server.cc:1819:3
    #10 0x7fcfa364a50f in __libc_start_call_main (/lib64/libc.so.6+0x2750f) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136)

@bryancall bryancall added the Leak label Jan 20, 2023
@bryancall bryancall added this to the 10.0.0 milestone Jan 20, 2023
@bryancall bryancall requested a review from brbzull0 January 20, 2023 21:49
@bryancall bryancall self-assigned this Jan 20, 2023
@bryancall bryancall requested a review from cmcfarlen January 27, 2023 20:34
@bryancall bryancall merged commit ec85728 into apache:10-Dev Jan 31, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
bb70c30 
* asf/master: (623 commits)
  records.config to records.yaml (apache#9264)
  Updates the release roadmap, adjusting for delays (apache#9360)
  Upgrades master branch to use clang-format v15.0.7 (apache#9355)
  Disable merging on GitHub (apache#9354)
  Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356)
  Enable merging for 10-Dev merge (apache#9353)
  Fix an error on SSL config reload (plus some cleanup). (apache#9334)
  Cleanup of legacy, makes newer clang-format crash right now (apache#9350)
  Update the roadmap / branch management doc page (apache#9340)
  Proxy Protocol out fixes (apache#9341)
  Memory leaks with storing configuration filenames (apache#9324)
  s3_auth autest: convert from gold file to file contains (apache#9337)
  Make 204 cacheable again (apache#9333)
  Add param to forward headers from the auth server to the origin (apache#9271)
  s3_auth: Fix assertion failure of TSActionCancel (apache#9329)
  Added http connect Autest with proxy verifier (apache#9315)
  s3_auth: Schedule reloading config event on TASK thread (apache#9328)
  Register ET_UDP thread type even if no UDP threads are requested (apache#9314)
  Don't send response body on status 204 No Content (apache#9330)
  Limit the serching range of static table by the first letter of header name (apache#9298)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randall randall randall approved these changes

@cmcfarlen cmcfarlen cmcfarlen approved these changes

@brbzull0 brbzull0 brbzull0 approved these changes

Assignees

@bryancall bryancall

Labels

Leak

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bryancall @randall @cmcfarlen @brbzull0