-
Notifications
You must be signed in to change notification settings - Fork 845
Upgrades master branch to use clang-format v15.0.7 #9355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
39977f9 to
bbcf771
Compare
|
[approve ci] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested the binaries on aarch64.
| for (int i = 0; i < numTok; i++) { | ||
| const char *current = pTok[i]; | ||
| int cnt = sz += strlen(current); | ||
| int cnt = sz += strlen(current); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting change. Most of the other changes add alignment with the previous = or whatever, this removes it. (This isn't a problem, just something that caught my eye.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, there are still imperfections :).
bneradt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through about half of these files, up until github was autohiding the files because of the volume. I then ignored white space changes, which highlighted the changes that added or removed newlines.
I didn't see any changes I didn't like. I think these changes are an improvement and will make things more readable.
Thanks for keeping clang-format updated.
|
And I do definitely like having the arm64 clang-format binaries. That makes running clang-format much quicker on my system. |
* asf/master: (623 commits) records.config to records.yaml (apache#9264) Updates the release roadmap, adjusting for delays (apache#9360) Upgrades master branch to use clang-format v15.0.7 (apache#9355) Disable merging on GitHub (apache#9354) Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356) Enable merging for 10-Dev merge (apache#9353) Fix an error on SSL config reload (plus some cleanup). (apache#9334) Cleanup of legacy, makes newer clang-format crash right now (apache#9350) Update the roadmap / branch management doc page (apache#9340) Proxy Protocol out fixes (apache#9341) Memory leaks with storing configuration filenames (apache#9324) s3_auth autest: convert from gold file to file contains (apache#9337) Make 204 cacheable again (apache#9333) Add param to forward headers from the auth server to the origin (apache#9271) s3_auth: Fix assertion failure of TSActionCancel (apache#9329) Added http connect Autest with proxy verifier (apache#9315) s3_auth: Schedule reloading config event on TASK thread (apache#9328) Register ET_UDP thread type even if no UDP threads are requested (apache#9314) Don't send response body on status 204 No Content (apache#9330) Limit the serching range of static table by the first letter of header name (apache#9298) ...
In addition to the upgrade to v15.0.7, with its new features and fixes, this also adds binaries for aarch64 platforms for both Linux and macOS.