Make Http3App class responsible for H3 transaction creation/deletion #9346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
force-pushed
the
cleanup_h3_txn_deletion
branch
from
a1bab3f to
9a3b1b6
Compare
maskit
force-pushed
the
cleanup_h3_txn_deletion
branch
from
9a3b1b6 to
da68d2c
Compare
maskit
commented
Feb 7, 2023
proxy/http3/Http3Session.cc
Outdated
| HQTransaction *t = this->_transaction_list.head; | ||
| while (t) { | ||
| ink_assert(t); | ||
| auto x = t; |
Member
Author
There was a problem hiding this comment.
I realized we can't simply do t->link.next because it's already deleted.
maskit
force-pushed
the
cleanup_h3_txn_deletion
branch
from
f94a563 to
eb5ffd8
Compare
maskit
commented
Feb 7, 2023
| delete t; | ||
| } | ||
| // Transactions should be deleted first before HQSesson gets deleted. | ||
| ink_assert(this->_transaction_list.head); |
Member
Author
There was a problem hiding this comment.
We originally had cleanup code here, but I realized that deleting a transaction modifies the transaction list. I removed the cleanup code since it was just a safety net.
Contributor
|
[approve ci] |
brbzull0
approved these changes
Apr 7, 2023
Contributor
brbzull0
left a comment
brbzull0
left a comment
There was a problem hiding this comment.
I don't see any issues with this change. Looks good to me. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.