Fix H3 transaction leak #9714
Merged
Fix H3 transaction leak #9714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
approved these changes
May 17, 2023
| case VC_EVENT_READ_READY: | ||
| if (this->_read_event == data) { | ||
| this->_read_event = nullptr; | ||
| } |
Contributor
There was a problem hiding this comment.
funny the way complier complains about [[fallthrough]] as here seems not to care (probably because it just breaks)
| { | ||
| // TODO: start closing transaction | ||
| super::transaction_done(); | ||
| delete this; |
Member
Author
There was a problem hiding this comment.
I'm not a big fun of this pattern too, but this is probably the right place to delete/free/release transaction instance if we follow the design. H2 tries to free transactions here and there and it's a mess, but If you look at H1ClientTransaction, it's released here in transaction_done().
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Fix ttmsh log field (apache#9722) Add CentOS to the required builds (apache#9721) Fix H3 transaction leak (apache#9714) Only need to include eventfd for native mode. This was using the wrong define anyway (apache#9711) Cleanup: remove ts::Buffer from LogField. (apache#9665) Cleanup: remove ts::Buffer from URL.cc (apache#9663) Check the calling thread of Ethread::schedule_local (apache#9691) build_h3_tools.sh: Remove an unneeded dir check (apache#9710) autoconf: Add lib flags for the quiche build test. (apache#9679) Remove deprecated debug output functions from 13 source files. (apache#9676) Changes for C++23 (apache#9703) QUIC: Add a unit tests to validate that the qlog file is generated (and no crashes) (apache#9668) libswoc: Update to 1.4.10 (apache#9700) Reload hosting.config on TASK thread (apache#9699) Changes for C++20 (apache#9701) Make io_uring or thread AIO modes a startup time decision (vs compile time) (apache#9630) Replace curl with proxy verifier in proxy protocol tests (apache#9684) Fix event queue corruption on PreWarmManager::reconfigure (apache#9692) Fixes crashes around OCSP with FetchSM (apache#9672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9346 made memory leak, assertion failures, and crashes.