Skip to content

Conversation

@masaori335
Copy link
Contributor

On top of the ts::bravo::shared_lock change (#9394), replace ink_rwlock g_records_rwlock with it.
The difference is noticeable when plugins call Rec* APIs through TSAPIs.

Benchmark

CPU

  • Intel(R) Xeon(R) Gold 5218 CPU @ 2.30GHz
  • 64 core

Client

  • Run 8 wrk2 processes against 8 different URLs

ATS

  • Enable remap_stats.so in the plugin.config
  • Set exec_thread.limit: 64

Results

  • Vanilla master: 554388 req/sec
  • With ts::bravo::shared_lock: 582533 req/sec

@masaori335 masaori335 added this to the 10.0.0 milestone Feb 9, 2023
@masaori335 masaori335 self-assigned this Feb 9, 2023
@bryancall bryancall requested a review from ywkaras February 13, 2023 23:19
@masaori335 masaori335 force-pushed the bravo-xsync-stats branch from 407f260 to 1ae0cd7 Compare May 5, 2023 13:16
@masaori335 masaori335 force-pushed the bravo-xsync-stats branch from 1ae0cd7 to 65345af Compare May 23, 2023 01:00
@masaori335 masaori335 marked this pull request as ready for review May 23, 2023 01:01
@apache apache deleted a comment from ezelkow1 May 23, 2023
@apache apache deleted a comment from bryancall May 23, 2023
@masaori335
Copy link
Contributor Author

Rebased on the latest master branch with the Bravo.h. This is ready for review.

@ywkaras ywkaras removed their request for review May 23, 2023 01:28
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

@github-actions github-actions bot added the Stale label Aug 21, 2023
@github-actions github-actions bot closed this Aug 28, 2023
@zwoop zwoop removed this from the 10.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants