Cleanup: records.config cleanup for references and comments. #9408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
force-pushed
the
records_config_ref_cleanup
branch
from
e390759 to
5583424
Compare
cmcfarlen
reviewed
Feb 14, 2023
ci/jenkins/bin/cache-tests.sh
Outdated
| ${PREFIX}/bin/trafficserver start | ||
| sleep 5 | ||
| ${PREFIX}/bin/traffic_ctl config set proxy.config.http.negative_caching_enabled 1 | ||
| sleep 5 |
Contributor
There was a problem hiding this comment.
This sleep here isn't very exciting. If we installed yq to the ci image you could do: yq -i '.ts.http.negative_caching_enabled=1' $RECORDS before starting traffic server. Or if traffic_ctl could do the out-of-band edit.
Contributor
Author
There was a problem hiding this comment.
True.
traffic_ctl will take care of that. I’ll link this PR the other(traffic_ctl --cold) PR.
thanks
randall
reviewed
Feb 14, 2023
plugins/experimental/url_sig/README
Outdated
| To enable the TSDebug verbose logging, change records.config to have: | ||
| To enable the TSDebug verbose logging, change records.yaml to have: | ||
|
|
||
| CONFIG proxy.config.diags.debug.enabled INT 1 |
Contributor
There was a problem hiding this comment.
should these lines be converted to yaml?
Contributor
|
Are you going to address Chris' concerns, or that for another PR? Your comment isn't clear. :). |
Contributor
Author
Yes, different PR. #9404 |
randall
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more clean up around the records.config