records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file #9404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
force-pushed
the
records_load_all_docs
branch
5 times, most recently
from
0f2ea79 to
0a1436c
Compare
brbzull0
changed the title
brbzull0
changed the title
cmcfarlen
requested changes
Feb 20, 2023
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
looks good. just some comment cleanup.
src/traffic_ctl/CtrlCommands.cc
Outdated
| } // namespace | ||
|
|
||
| // } // namespace | ||
| // using namespace print_utils; |
stream/file. This will work as the legacy records.config where a later variable would override a previous value.
brbzull0
force-pushed
the
records_load_all_docs
branch
from
0a1436c to
dc28bbb
Compare
cmcfarlen
approved these changes
Feb 20, 2023
Contributor
|
This will help to build tooling around records.yaml. Thanks so much! |
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (49 commits) Cleanup: removing some traffic_manager leftovers. (apache#9425) records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file (apache#9404) QUIC-quiche: Use configured disable_active_migration param at quiche transport configuration. (apache#9447) records.yaml: Make sure we fail if we found a legacy records.config file. (apache#9435) Use TSDbg in webp_transform plugin (apache#9439) quic: make sure we create a stream if none available. (apache#9436) Fixes comparison with the wrong type (apache#9441) On arm64 macOS, do not use pagezero linker flag when using luajit (apache#9430) tscore: Remove unneeded and mispelled libswoc reference. (apache#9429) Remove UDP_stubs.h (apache#9413) Make jsonrcp restricted_api false by default. (apache#9415) Histogram: rename members because Zwoop. (apache#9417) FileManager string update (apache#9416) P_SSLUtils.h include updates (apache#9414) libswoc: update build support to fix issues with 10-Dev merge. (apache#9397) QUIC: Remove hardcoded quiche set_initial_max_streams and use config values instead. (apache#9412) Fixes the compile to work with LLVM15 (apache#9410) update cmake for rpc and swoc (apache#9409) Removes the UglyStub file (apache#9401) TSan: Make Thread::cur_time thread local (apache#9184) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes 2 changes.
1 - Support for loading multiple YAML documents from the same
records.yamlfile. This is done basically to keep the same behavior as we had before withrecords.configwhere the latest config set overwrites a previous set. So basically:records.yaml:So,
enabled=1will be the variable value after loading.2 - Add support for modifying a
records.yamlfile usingtraffic_ctl, this will lettraffic_ctlto:traffic_ctl config set proxy.config.diags.debug.enabled 1 -c [file]traffic_ctl config set proxy.config.diags.debug.enabled 1 -u -c [file]records.yamlfiletraffic_ctldocs are updated to reflect these changes.#9384