TSan: Make Thread::cur_time thread local #9184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
SolidWallOfCode
approved these changes
Feb 13, 2023
Contributor
|
We'd like to see this in the 9.2.x tree, but my recommendation is that we wait for v9.2.2, since we need to make a safe, stable v9.2.1 soon. |
Contributor
Author
|
We haven't seen any issue with this change so far, but I'm +1 for v9.2.2 for the stability of v9.2.1 release. A note is this change made 18% improvement on the high rps benchmark. I'm surprised by that, but it makes sense because the |
zwoop
pushed a commit
that referenced
this pull request
May 30, 2023
(cherry picked from commit 72e6602)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
(cherry picked from commit 72e6602) Co-authored-by: Masaori Koshiba <masaori@apache.org>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
* Revert "Gauge to Counter metrics for CDN Harmony (apache#544)" This reverts commit 1a83589. * Revert "[9.2.x] Improve performance of finding SNI Actions (apache#541)" This reverts commit 21cbfc0. * Revert "TSan: Make Thread::cur_time thread local (apache#9184) (apache#537)" This reverts commit d93ac0e. * Revert "Fix a crash in FetchSM (apache#546)" This reverts commit e03b829. * Revert "Remove dependency on OpenSSL's OCSP API (apache#538)" This reverts commit 00ad803. * Revert "Fix crashes on OCSP requests (apache#543)" This reverts commit bbb41b9. * Revert "Add OTHER to cipher TLS cipher metrics (apache#542)" This reverts commit 74dbd97. * Revert "rio: use bazinga-boringssl 19.x for boringssl build (apache#540)" This reverts commit 9c57330. * Revert "Use FetchSM for OCSP HTTP requests (apache#535)" This reverts commit dbd0ec7. * Do not schedule reconfigure event on schedule_imm_local Co-authored-by: Mo Chen <mochen@apache.org> Co-authored-by: Serris Lew <lserris@apple.com>
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Feb 6, 2024
…he#837) Properties percieved a performance degredation when cur_time was made thread_local. This was likely because each thread had its own cached version of cur_time and thus didn't get updated as frequently as the global one used to be. There are ideas about how to address this patch better, but in the meantime we plan to simply revert the patch. This reverts commit 371ff9a.
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
Feb 6, 2024
…" (apache#837)" This reverts commit 8d513d2.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (49 commits) Cleanup: removing some traffic_manager leftovers. (apache#9425) records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file (apache#9404) QUIC-quiche: Use configured disable_active_migration param at quiche transport configuration. (apache#9447) records.yaml: Make sure we fail if we found a legacy records.config file. (apache#9435) Use TSDbg in webp_transform plugin (apache#9439) quic: make sure we create a stream if none available. (apache#9436) Fixes comparison with the wrong type (apache#9441) On arm64 macOS, do not use pagezero linker flag when using luajit (apache#9430) tscore: Remove unneeded and mispelled libswoc reference. (apache#9429) Remove UDP_stubs.h (apache#9413) Make jsonrcp restricted_api false by default. (apache#9415) Histogram: rename members because Zwoop. (apache#9417) FileManager string update (apache#9416) P_SSLUtils.h include updates (apache#9414) libswoc: update build support to fix issues with 10-Dev merge. (apache#9397) QUIC: Remove hardcoded quiche set_initial_max_streams and use config values instead. (apache#9412) Fixes the compile to work with LLVM15 (apache#9410) update cmake for rpc and swoc (apache#9409) Removes the UglyStub file (apache#9401) TSan: Make Thread::cur_time thread local (apache#9184) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative (original) approach of #9168 to fix the data race.