Make jsonrcp restricted_api false by default. #9415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making restricted_api false by default will cause ATS to enforce socket permissions rather than relying upon the DAC of the socket. With this change, ATS will restrict access to privileged users for write operations while allowing broader access for read-only options. Thus `traffic_ctl config get` will be generally accessible since it is a read-only operation, while `traffic_ctl config set` will require privilege since it modifies the configuration. This default should be reasonable since that is how 9.0 used to behave.
zwoop
approved these changes
Feb 15, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (49 commits) Cleanup: removing some traffic_manager leftovers. (apache#9425) records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file (apache#9404) QUIC-quiche: Use configured disable_active_migration param at quiche transport configuration. (apache#9447) records.yaml: Make sure we fail if we found a legacy records.config file. (apache#9435) Use TSDbg in webp_transform plugin (apache#9439) quic: make sure we create a stream if none available. (apache#9436) Fixes comparison with the wrong type (apache#9441) On arm64 macOS, do not use pagezero linker flag when using luajit (apache#9430) tscore: Remove unneeded and mispelled libswoc reference. (apache#9429) Remove UDP_stubs.h (apache#9413) Make jsonrcp restricted_api false by default. (apache#9415) Histogram: rename members because Zwoop. (apache#9417) FileManager string update (apache#9416) P_SSLUtils.h include updates (apache#9414) libswoc: update build support to fix issues with 10-Dev merge. (apache#9397) QUIC: Remove hardcoded quiche set_initial_max_streams and use config values instead. (apache#9412) Fixes the compile to work with LLVM15 (apache#9410) update cmake for rpc and swoc (apache#9409) Removes the UglyStub file (apache#9401) TSan: Make Thread::cur_time thread local (apache#9184) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making restricted_api false by default will cause ATS to enforce socket permissions rather than relying upon the DAC of the socket. With this change, ATS will restrict access to privileged users for write operations while allowing broader access for read-only options. Thus
traffic_ctl config getwill be generally accessible since it is a read-only operation, whiletraffic_ctl config setwill require privilege since it modifies the configuration. This default should be reasonable since that is how 9.0 used to behave.