Skip to content

Fixes the compile to work with LLVM15 #9410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwoop merged 1 commit into from
Feb 15, 2023
Merged

Fixes the compile to work with LLVM15 #9410

zwoop merged 1 commit into from
Feb 15, 2023

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Feb 14, 2023

No description provided.

@zwoop zwoop added the Build work related to build configuration or environment label Feb 14, 2023
@zwoop zwoop added this to the 10.0.0 milestone Feb 14, 2023
@zwoop zwoop self-assigned this Feb 14, 2023
@zwoop
Copy link
Contributor Author

zwoop commented Feb 14, 2023

Unclear why clang v15 is so finicky here, but one of these sizes is a size_t, so heck, just cast to it and use the appropriate printf for it (%zu).

@maskit
Copy link
Member

maskit commented Feb 15, 2023 

static constexpr ts_milliseconds LOOP_HISTOGRAM_BUCKET_SIZE{5};
using ts_milliseconds = std::chrono::milliseconds;

std::chrono::microseconds | duration</*signed integer type of at least 55 bits*/, std::micro>

maskit
maskit approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

@zwoop zwoop merged commit 496adcf into apache:master Feb 15, 2023
@zwoop zwoop deleted the LLVM15 branch February 15, 2023 16:14
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
03b605e 
* asf/master: (49 commits)
  Cleanup: removing some traffic_manager leftovers. (apache#9425)
  records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file (apache#9404)
  QUIC-quiche: Use configured disable_active_migration param at quiche transport configuration. (apache#9447)
  records.yaml: Make sure we fail if we found a legacy records.config file. (apache#9435)
  Use TSDbg in webp_transform plugin (apache#9439)
  quic: make sure we create a stream if none available. (apache#9436)
  Fixes comparison with the wrong type (apache#9441)
  On arm64 macOS, do not use pagezero linker flag when using luajit (apache#9430)
  tscore: Remove unneeded and mispelled libswoc reference. (apache#9429)
  Remove UDP_stubs.h (apache#9413)
  Make jsonrcp restricted_api false by default. (apache#9415)
  Histogram: rename members because Zwoop. (apache#9417)
  FileManager string update (apache#9416)
  P_SSLUtils.h include updates (apache#9414)
  libswoc: update build support to fix issues with 10-Dev merge. (apache#9397)
  QUIC: Remove hardcoded quiche set_initial_max_streams and use config values instead. (apache#9412)
  Fixes the compile to work with LLVM15 (apache#9410)
  update cmake for rpc and swoc (apache#9409)
  Removes the UglyStub file (apache#9401)
  TSan: Make Thread::cur_time thread local (apache#9184)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maskit maskit maskit approved these changes

@SolidWallOfCode SolidWallOfCode Awaiting requested review from SolidWallOfCode

Assignees

@zwoop zwoop

Labels

Build work related to build configuration or environment

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zwoop @maskit