Skip to content

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Feb 26, 2023

In my tests (not particularly scientific), this is about 10% more RPS (faster), while at the same time over 40% lower latency on first response byte. Yes, this can be accomplished without a new configure option, I just find this more convenient.

I've only tested this with LLVM.

@zwoop zwoop added Build work related to build configuration or environment Performance labels Feb 26, 2023
@zwoop zwoop added this to the 10.0.0 milestone Feb 26, 2023
@zwoop zwoop requested review from bneradt and bryancall February 26, 2023 21:22
@zwoop zwoop self-assigned this Feb 26, 2023
@zwoop zwoop force-pushed the LTO branch 2 times, most recently from c669536 to 3603c14 Compare February 26, 2023 21:24
@zwoop zwoop requested a review from ezelkow1 February 27, 2023 16:09
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I assume this doesn't increase build times too much?

@zwoop
Copy link
Contributor Author

zwoop commented Feb 27, 2023

I've updated this with some input from smart people (thanks Randall and Craig).

bneradt
bneradt previously approved these changes Feb 27, 2023
@zwoop zwoop merged commit 6cc6027 into apache:master Feb 28, 2023
@zwoop zwoop deleted the LTO branch February 28, 2023 15:50
zwoop added a commit that referenced this pull request Mar 6, 2023
@zwoop
Copy link
Contributor Author

zwoop commented Mar 6, 2023

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.1 Mar 6, 2023
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Apr 4, 2023
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Jul 24, 2023
(cherry picked from commit 6cc6027)
(cherry picked from commit b6adc86)
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (28 commits)
  Human readable timestamp for traffic_ctl config status (apache#9440)
  traffic_ctl - Remove legacy/pretty format output options (apache#9471)
  TSAN fix for fake_global_for_ink_queue. (apache#9183)
  libswoc: replace TextView in src/tscore/HostLookup.cc (apache#9437)
  records.yaml: Make sure when a string field is set to NULL then this (apache#9472)
  QUIC: Make sure the some of the quic configs get set into the quiche impl. (apache#9477)
  Replace httpbin with go-httpbin (apache#9475)
  Ethread::process_event(): make sure event mutex is unlocked before freeing event. (apache#9433)
  Use deprecated OpenSSL APIs for MD5 and SHA256 if available (apache#9469)
  Adds a --enable-lto option (Link Time Optimization) (apache#9464)
  traffic_ctl: Add support to monitor metrics. (apache#9423)
  QUIC: Make some adjustment to the qlog configuration (apache#9461)
  Added more debugging output for the xdebug plugin (apache#9467)
  Build: remove configure check for sys/mount.h, use C++17 builtin. (apache#9463)
  Fix SSLSessionDup for old OpenSSL and BoringSSL (apache#9444)
  Run autest tls_hooks17 and tls_hooks18 on BoringSSL build (apache#9455)
  Stabilize autest tls_hook18 (apache#9454)
  Fix parameter parser in ssl_hook_test plugin (apache#9453)
  Use SSL_get1_peer_certificate on OpenSSL3 build (apache#9460)
  records.yaml - Make some changes on the convert script. (apache#9466)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants