traffic_ctl - Remove legacy/pretty format output options. #9471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide any value to the tool.
brbzull0
force-pushed
the
traffic_ctl_make_output_format_simple
branch
from
6f1a17a to
269e00d
Compare
brbzull0
changed the title
SolidWallOfCode
approved these changes
Mar 1, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (28 commits) Human readable timestamp for traffic_ctl config status (apache#9440) traffic_ctl - Remove legacy/pretty format output options (apache#9471) TSAN fix for fake_global_for_ink_queue. (apache#9183) libswoc: replace TextView in src/tscore/HostLookup.cc (apache#9437) records.yaml: Make sure when a string field is set to NULL then this (apache#9472) QUIC: Make sure the some of the quic configs get set into the quiche impl. (apache#9477) Replace httpbin with go-httpbin (apache#9475) Ethread::process_event(): make sure event mutex is unlocked before freeing event. (apache#9433) Use deprecated OpenSSL APIs for MD5 and SHA256 if available (apache#9469) Adds a --enable-lto option (Link Time Optimization) (apache#9464) traffic_ctl: Add support to monitor metrics. (apache#9423) QUIC: Make some adjustment to the qlog configuration (apache#9461) Added more debugging output for the xdebug plugin (apache#9467) Build: remove configure check for sys/mount.h, use C++17 builtin. (apache#9463) Fix SSLSessionDup for old OpenSSL and BoringSSL (apache#9444) Run autest tls_hooks17 and tls_hooks18 on BoringSSL build (apache#9455) Stabilize autest tls_hook18 (apache#9454) Fix parameter parser in ssl_hook_test plugin (apache#9453) Use SSL_get1_peer_certificate on OpenSSL3 build (apache#9460) records.yaml - Make some changes on the convert script. (apache#9466) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR;
pretty|legacyaren't really needed anymore(or ever for what is worth).They were introduced to help with the migration from the old mgmt api to the jsonrpc, the idea was to keep the legacy output messages as well as new ones if needed. This was never used, legacy and pretty can both live together without the need to have them separated.
If something this was only adding complexity.
This is a cleanup, no new feature and it does not break anything.