Hugepage config cleanup #9479
Merged
Hugepage config cleanup #9479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
reviewed
Mar 1, 2023
iocore/eventsystem/IOBuffer.cc
Outdated
| } | ||
|
|
||
| auto x = ts::svto_radix<10>(token); | ||
| if (token.empty() && x <= std::numeric_limits<int>::max()) { |
Contributor
There was a problem hiding this comment.
This may break in ubuntu x <= std::numeric_limits<int>::max(), you fixed this already ;)
Contributor
Author
There was a problem hiding this comment.
oops, unfixed! Thanks!
Contributor
Author
There was a problem hiding this comment.
I do wish svto_radix returned std::optional or something!
cmcfarlen
force-pushed
the
hugepage-config-cleanup
branch
from
e46559f to
93f4506
Compare
…e. Now just use the proxy.config.allocator.hugepages config for both
cmcfarlen
force-pushed
the
hugepage-config-cleanup
branch
from
058e4e1 to
abf16d6
Compare
Contributor
Author
|
[approve ci autest] |
ywkaras
reviewed
Mar 9, 2023
ywkaras
approved these changes
Mar 13, 2023
cmcfarlen
added a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* use libswoc to implement more user friendly format for configuring chunk buffer sizes * remove separate config items for iobuffer and cache dir entry hugepage. Now just use the proxy.config.allocator.hugepages config for both * Use Fatal with a message instead of exit --------- Co-authored-by: Chris McFarlen <cmcfarlen@apple.com>
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* commit 'c54a2e2b77151869ff014fbdc4c82cec0afcbb8c': (37 commits) Slight performance improvements before calling APIHooks::clear (apache#9480) libswoc: Update to 1.4.5 (apache#9522) CryptoContext: Clean up to avoid compiler problem. (apache#9521) Add TLSCertSwitchSupport (apache#9322) Add clang-format-tests to clang-format target (apache#9456) Adds the AR env variable to config.nice (apache#9515) Fix .asf.yaml (apache#9519) Hugepage config cleanup (apache#9479) Separate io_uring into a separate library. AIO in io_uring mode uses new io_uring lib. (apache#9462) Avoid memory allocation in CryptoHash (apache#9474) UnitParser: add unit parser support. (apache#9485) autest - Minor fix on the verifier_client test ext to allow setting only the http3 ports. (apache#9517) Remove support for port event polling (apache#9476) QUIC: Add support to configure UDP max payload limit. (apache#9486) Reduce the size of the APIHooks, eliminating enum gap (apache#9509) Add support for CMCD-Request header nor field to prefetch plugin (apache#9232) Eliminates padding from some common structs (apache#9481) Enable external file loading for sni.yaml. (apache#9501) Remove inactive include of IpMapConf.h (apache#9512) Cleanup: Remove RecModeT from the code. (apache#9487) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the following settings:
Instead, these features will just use the
proxy.config.allocator.hugepagessetting. This is to reduce the config required to get huge pages going.This PR also adds back in the hopefully more user friendly parsing of the iobuffer buckets. This is related because this was part of the prior hugepage work but was left out because libswoc was not linked to the binaries in the build system.