Enable external file loading for sni.yaml. #9501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from Yahoo's internal 9.1.x branch Conflicts: include/tscore/bwf_std_format.h iocore/net/P_SNIActionPerformer.h iocore/net/SSLSNIConfig.cc proxy/IPAllow.cc
lzx404243
force-pushed
the
ats-10-merge-external-file-loading-sni
branch
from
c5cf385 to
f3a7447
Compare
lzx404243
force-pushed
the
ats-10-merge-external-file-loading-sni
branch
from
f3a7447 to
aecea1d
Compare
bneradt
requested changes
Mar 6, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks great. Only one observation.
bneradt
approved these changes
Mar 6, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. As @lzx404243 mentioned, this is a cherry-pick to opensource of a Yahoo internal PR @shinrich created. I verified the port here and the way conflicts were resolved and it looks correct to me. It would be good to get a non-Yahoo reviewer though.
bneradt
requested changes
Mar 7, 2023
SolidWallOfCode
previously approved these changes
Mar 7, 2023
maskit
reviewed
Mar 7, 2023
bneradt
previously approved these changes
Mar 7, 2023
Contributor
|
Looks good. |
maskit
reviewed
Mar 8, 2023
maskit
reviewed
Mar 8, 2023
maskit
reviewed
Mar 8, 2023
maskit
reviewed
Mar 8, 2023
maskit
reviewed
Mar 8, 2023
maskit
reviewed
Mar 8, 2023
maskit
reviewed
Mar 8, 2023
maskit
approved these changes
Mar 8, 2023
Member
|
@bneradt @SolidWallOfCode I requested a couple of changes after your last reviews. Please go ahead and merge this PR if it looks good to you too. |
bneradt
approved these changes
Mar 9, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
Enable external file loading for sni.yaml for the ip_allow key so that a list of IP addresses can be specified in a separate file rather than listed out in the sni.yaml file.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* commit 'c54a2e2b77151869ff014fbdc4c82cec0afcbb8c': (37 commits) Slight performance improvements before calling APIHooks::clear (apache#9480) libswoc: Update to 1.4.5 (apache#9522) CryptoContext: Clean up to avoid compiler problem. (apache#9521) Add TLSCertSwitchSupport (apache#9322) Add clang-format-tests to clang-format target (apache#9456) Adds the AR env variable to config.nice (apache#9515) Fix .asf.yaml (apache#9519) Hugepage config cleanup (apache#9479) Separate io_uring into a separate library. AIO in io_uring mode uses new io_uring lib. (apache#9462) Avoid memory allocation in CryptoHash (apache#9474) UnitParser: add unit parser support. (apache#9485) autest - Minor fix on the verifier_client test ext to allow setting only the http3 ports. (apache#9517) Remove support for port event polling (apache#9476) QUIC: Add support to configure UDP max payload limit. (apache#9486) Reduce the size of the APIHooks, eliminating enum gap (apache#9509) Add support for CMCD-Request header nor field to prefetch plugin (apache#9232) Eliminates padding from some common structs (apache#9481) Enable external file loading for sni.yaml. (apache#9501) Remove inactive include of IpMapConf.h (apache#9512) Cleanup: Remove RecModeT from the code. (apache#9487) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-picked from Yahoo's internal 9.1.x branch and originally authored by @shinrich .
Conflicts:
include/tscore/bwf_std_format.h
iocore/net/P_SNIActionPerformer.h
iocore/net/SSLSNIConfig.cc
proxy/IPAllow.cc