Skip to content

Conversation

@brbzull0
Copy link
Contributor

This PR adds some basic unit tests to try out the ts.quic.no_activity_timeout_in record.

@brbzull0 brbzull0 added the QUIC label Mar 20, 2023
@brbzull0 brbzull0 added this to the 10.0.0 milestone Mar 20, 2023
@brbzull0 brbzull0 self-assigned this Mar 20, 2023
@brbzull0 brbzull0 force-pushed the basic_quic_no_activity_timeout_in branch 3 times, most recently from ab692d3 to 69b7d5b Compare March 21, 2023 13:01
@brbzull0 brbzull0 requested a review from maskit March 21, 2023 13:59
gold_file="gold/quic_no_activity_timeout.gold")
test1.run(check_for_max_idle_timeout=True)

test2 = Test_quic_no_activity_timeout(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this test for? Looks like checking the same thing with shorter times.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much yes. prob make no sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removed this one, I think once I have a fix for the crash issue I can enable the commented one.

@brbzull0 brbzull0 force-pushed the basic_quic_no_activity_timeout_in branch from 69b7d5b to d7ad4e7 Compare March 21, 2023 15:59
@brbzull0 brbzull0 marked this pull request as ready for review March 21, 2023 15:59
@brbzull0 brbzull0 requested a review from maskit March 21, 2023 17:50
@brbzull0 brbzull0 merged commit cac9adf into apache:master Mar 23, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (42 commits)
  Add logic to make the server.policy and server.properties settings reloadable (apache#9572)
  Add CMake to the required PR CI builds (apache#9575)
  fixup cmake build for master and add conditional for io_uring support (apache#9571)
  Cleanup: Use swoc::meta instead of ts::meta. (apache#9566)
  codeql 24: Multiplication result converted to larger type (apache#9569)
  Drop support for old quiche (apache#9561)
  QUIC: Ignore default_inactivity_timeout in favour of proxy.config.quic.no_activity_timeout_in. (apache#9564)
  Fix log format specifications (apache#9568)
  Add `current_time_epoch_ms` stat to be appended before the server version. This allows computation of stats externally based on the cache time frame. This can help alleviate issues with sliding windows between various stats programs that generate discrepencies (apache#9567)
  Define BIO macros in ink_ssl.h (apache#9557)
  combine UDPPacket and UDPPacketInternal (apache#9424)
  Update codeql.yml (apache#9560)
  Http2 to origin (apache#9366)
  coverity 1497413: Use of 32-bit time_t (apache#9556)
  Add support for multiple yaml config files for wasm plugin (apache#9483)
  Add TS_HAS_QUICHE feature variable. (apache#9547)
  mime header field parsing fix trailing quote handlling (apache#9513)
  Make magick plugin buildable with BoringSSL (apache#9554)
  QUIC: Test basic scenarios around the ts.quic.no_activity_timeout_in config. (apache#9543)
  Fix records events deps (apache#9511)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants