Skip to content

Conversation

@brbzull0
Copy link
Contributor

@brbzull0 brbzull0 commented Mar 21, 2023

Some of the quic features may only work with the quiche implementation. Having this will make easy in particular for unit tests to opt out depending of the variable value.

Exmaple:

Test.SkipUnless(
   Condition.HasATSFeature('TS_HAS_QUICHE')
)

This also makes the variable available for all binaries.

/opt/ats/bin/traffic_layout info --features | grep QUICHE
#define TS_HAS_QUICHE 1

work with the quiche implementation. Having this will make easy in
particular for unit tests to opt out depending of the variable value.
@brbzull0 brbzull0 added this to the 10.0.0 milestone Mar 21, 2023
@brbzull0 brbzull0 requested a review from maskit March 21, 2023 12:47
@brbzull0 brbzull0 self-assigned this Mar 21, 2023
@brbzull0
Copy link
Contributor Author

[approve ci autest]

@maskit
Copy link
Member

maskit commented Mar 21, 2023

HAVE_QUICHE_H is used at some places. We might want to consistently use TS_HAS_QUICHE if we add it.

@brbzull0
Copy link
Contributor Author

brbzull0 commented Mar 21, 2023

HAVE_QUICHE_H is used at some places. We might want to consistently use TS_HAS_QUICHE if we add it.

you mean change all the HAVE_QUICHE_H usage and use TS_HAS_QUICHE instead?

@maskit
Copy link
Member

maskit commented Mar 21, 2023

you mean change all the HAVE_QUICHE_H usage and use TS_HAS_QUICHE instead?

Yes, I'm fine with either one but using the both may cause confusion.

@brbzull0 brbzull0 marked this pull request as draft March 22, 2023 12:00
@brbzull0 brbzull0 force-pushed the add_quiche_feature_variable branch from 4398721 to 3aa5d10 Compare March 22, 2023 17:27
@brbzull0 brbzull0 force-pushed the add_quiche_feature_variable branch from 3aa5d10 to 19a6553 Compare March 22, 2023 19:17
@brbzull0
Copy link
Contributor Author

[approve ci autest]

@brbzull0 brbzull0 marked this pull request as ready for review March 23, 2023 17:45
Copy link
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brbzull0 brbzull0 merged commit ef01a71 into apache:master Mar 24, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (42 commits)
  Add logic to make the server.policy and server.properties settings reloadable (apache#9572)
  Add CMake to the required PR CI builds (apache#9575)
  fixup cmake build for master and add conditional for io_uring support (apache#9571)
  Cleanup: Use swoc::meta instead of ts::meta. (apache#9566)
  codeql 24: Multiplication result converted to larger type (apache#9569)
  Drop support for old quiche (apache#9561)
  QUIC: Ignore default_inactivity_timeout in favour of proxy.config.quic.no_activity_timeout_in. (apache#9564)
  Fix log format specifications (apache#9568)
  Add `current_time_epoch_ms` stat to be appended before the server version. This allows computation of stats externally based on the cache time frame. This can help alleviate issues with sliding windows between various stats programs that generate discrepencies (apache#9567)
  Define BIO macros in ink_ssl.h (apache#9557)
  combine UDPPacket and UDPPacketInternal (apache#9424)
  Update codeql.yml (apache#9560)
  Http2 to origin (apache#9366)
  coverity 1497413: Use of 32-bit time_t (apache#9556)
  Add support for multiple yaml config files for wasm plugin (apache#9483)
  Add TS_HAS_QUICHE feature variable. (apache#9547)
  mime header field parsing fix trailing quote handlling (apache#9513)
  Make magick plugin buildable with BoringSSL (apache#9554)
  QUIC: Test basic scenarios around the ts.quic.no_activity_timeout_in config. (apache#9543)
  Fix records events deps (apache#9511)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants