Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tvm explorer infrastructure #92

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Tvm explorer infrastructure #92

merged 2 commits into from
Oct 17, 2022

Conversation

chunit-quic
Copy link
Contributor

Hi community:

Follow the guide in the README.md, this PR is summited for the forum topic:
https://discuss.tvm.apache.org/t/tvm-explorer-infrastructure/13457
Thank you!

Joey Tsai added 2 commits September 1, 2022 10:08
[TVM Explorer Infrastructure]
29426b4 
- Enchance the span filling
- Enchance the schedule visualization
[tvm_explorer_infrastructure]
27e7cfb 
- Rebased
@chunit-quic chunit-quic force-pushed the tvm_explorer_infrastructure branch from 9058a33 to 27e7cfb Compare September 1, 2022 03:31
tkonolige
tkonolige approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this work the improve debugging in TVM! I think this is a great step forward.

rfcs/0092-TVM-Explorer-Infrastructure.md
# Drawbacks
[drawbacks]: #drawbacks

* Process extra debug information would cause longer compilation time:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done any tests to see how much this may increase compile times? My guess is it would not be too bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tkonolige,
Thanks for comments! :D
Yes, we have a profiling results in the forum.
For your reference. You can find the details in the end of this post.
https://discuss.tvm.apache.org/t/pre-rfc-tvm-explorer-infrastructure/13457/14?u=chunit

@areusch areusch merged commit dcfe8cd into apache:main Oct 17, 2022
@areusch
Copy link
Contributor

areusch commented Oct 17, 2022

i think we are good on the pre-RFC thread, let's merge this then. @chunit-quic can you create an RFC tracking issue (i.e. "feature tracking" here) for this one?

@chunit-quic chunit-quic mentioned this pull request Oct 18, 2022
Open
9 tasks
@chunit-quic
Copy link
Contributor Author

i think we are good on the pre-RFC thread, let's merge this then. @chunit-quic can you create an RFC tracking issue (i.e. "feature tracking" here) for this one?

Hi @areusch ,
Thanks a lot for your help! :D
I have created the tracking issue and here is the link. Thank you. :)

@chunit-quic chunit-quic mentioned this pull request Nov 16, 2022
Merged
This was referenced Jan 9, 2023
Merged
Merged
Merged
@chunit-quic chunit-quic mentioned this pull request Feb 20, 2023
Merged
@chunit-quic chunit-quic mentioned this pull request Mar 2, 2023
Merged
@chunit-quic chunit-quic mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkonolige tkonolige tkonolige approved these changes

@areusch areusch areusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunit-quic @areusch @tkonolige