-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TE] Record primitives of Schedule for visualization #14168
Conversation
chunit-quic
commented
Mar 2, 2023
- Make Stage link to its Schedule via attach_sch.
- Add two array attributes, primitive_record and schedule_record to Schedule.
- Create a new class, ScheduleContext, to record primitives.
- Register a pass config variable, keep_schedule_record to enable/disable the recording.
- Add test cases for TEDD, build_module and schedule ops.
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hi community, This is second part of TVM Explorer infrastructures. After this patch, user can backtrack what To give you more context, we briefly describe what have been done below in this PR. Here is the
Everytime a Stage being modified by a primitive, we will use ScheduleContext to record the optimized schedule and corresponding primitive. So that we can obtain the modification sequence later. You can reference to preRFC for more details. Thanks! For your reference, here is the related links. |
fd4b1da
to
3547d63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I'm not confident to explicitly approve it since I'm not an expert on TE
78c3d62
to
8b14890
Compare
- Make Stage link to its Schedule via attach_sch. - Add two array attributes, primitive_record and schedule_record to Schedule. - Create a new class, ScheduleContext, to record primitives. - Register a pass config variable, keep_schedule_record to enable/disable the recording. - Add test cases for TEDD, build_module and schedule ops.
8b14890
to
1c5ce66
Compare
Hi @Hzfengsy,
Thank you for reviewing! May I know is there any recommended person who could help to review this topic? :) Hi @masahi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chunit-quic for the PR. I explicitly approve this PR after another look. Let's merge it in 24h if there are no other objectives.
No problem. Thanks a lot for helping us! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix basic grammar issues.
* Fix grammar issues * Rewrite unclear comments
Hi @masahi, Thank you very much for reviewing! Thank you! |
* Remove the wrong term, rebased in comments and variables.