Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRT] Add check to support split op with TRT 5.1.5+ #11154

Merged
merged 1 commit into from
May 2, 2022
Merged

[TRT] Add check to support split op with TRT 5.1.5+ #11154

merged 1 commit into from
May 2, 2022

Conversation

apivovarov
Copy link
Contributor

@apivovarov apivovarov commented Apr 27, 2022 •
edited
Loading

SplitOpConverter uses nvinfer1::INetworkDefinition::addSlice which is not available before TRT 5.1.5
This PR adds a check to support split op with TRT 5.1.5+

Related PR: #7967

@apivovarov
Copy link
Contributor Author

@comaniac @ziyu-guo Can you have a look?

ziyu-guo
ziyu-guo approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@ziyu-guo ziyu-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac
Copy link
Contributor

LGTM. Please also update the document: https://tvm.apache.org/docs/how_to/deploy/tensorrt.html

@apivovarov
Copy link
Contributor Author

LGTM. Please also update the document: https://tvm.apache.org/docs/how_to/deploy/tensorrt.html

Done. Added conv1d op to Operator support table as well.

@apivovarov
Copy link
Contributor Author

@masahi @vinx13 @comaniac Can you merge it?

@comaniac comaniac merged commit 9284d32 into apache:main May 2, 2022
@comaniac
Copy link
Contributor

comaniac commented May 2, 2022

Thanks @apivovarov @ziyu-guo

@apivovarov apivovarov mentioned this pull request May 2, 2022
Merged
@apivovarov apivovarov deleted the trt_split_515 branch May 2, 2022 19:04
apivovarov added a commit to neo-ai/tvm that referenced this pull request May 5, 2022
@apivovarov
[TRT] Add check to support split op with TRT 5.1.5+ (apache#11154)
ab835e2
apivovarov added a commit to neo-ai/tvm that referenced this pull request May 5, 2022
@apivovarov
[TRT] Add check to support split op with TRT 5.1.5+ (apache#11154)
21fc386
@apivovarov apivovarov mentioned this pull request May 6, 2022
Merged
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
@apivovarov
[TRT] Add check to support split op with TRT 5.1.5+ (apache#11154)
569df5b
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this pull request May 27, 2022
@apivovarov
[TRT] Add check to support split op with TRT 5.1.5+ (apache#11154)
3931345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyu-guo ziyu-guo ziyu-guo approved these changes

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apivovarov @comaniac @ziyu-guo