Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI] Expose mem_scope from generic conv2d variants to be more reusable #13680

Merged
merged 1 commit into from
Jan 3, 2023
Merged

[TOPI] Expose mem_scope from generic conv2d variants to be more reusable #13680

merged 1 commit into from
Jan 3, 2023

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented Jan 2, 2023

This small PR enhances generic conv2d TOPI schedules to be even more reusable.

Changes:

  1. Continues PR #6714 and expose memory scope via mem_scope
  2. Enhanches schedule_conv_NCHWc_cpu_common_int8 and schedule_conv_NCHWc_cpu_1x1_int8

Does not change current behaviour, memory scope remains "global" by default.

Goal:

Flexibility and reusability of key generic schedules is desirable for targets, especially custom ISA/ASIC.
There are use-cases where cache memory is not directly visible ("local") but generic TOPI is still very useful as-is.


Cc @masahi , @vinx13 , @ZihengJiang please help with the review.

Thank you,
~Cristian.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 2, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: topi See #10317 for details

Generated by tvm-bot

@masahi masahi merged commit e5a7f5f into apache:main Jan 3, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
…ble (apache#13680)

Expose mem_scope from generic conv2d variants to be more reusable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants