-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible conv2d_NCHWc_int8 generic operator. #6714
Conversation
Thanks for the explanation and for the pointers @cbalint13 ! This LGTM |
@giuseros , Thank you very much ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know I had the possibility to approve PRs without being a "reviewer". Apparently yes :)
@cbalint13 could you try restarting the CI? |
@vinx13 , done, passed. Thank You ! |
This small PR enable flexible parametrizations for
conv2d_NCHWc_int8()
int terms ofint32_lanes
andint8_elements
.Goal:
conv2d_NCHWc_int8()
to be called with any custom values ofint32_lanes
andint8_elements
Changes:
n_elems
(default=4) optional parameter instead of staticn_elems = 4
hardcode.int32_lane < int8_num_elements
too.@anijain2305 @zhiics @vinx13 @ZihengJiang please help me with the review,
Thank You !