Fix relax.ccl.scatter_from_worker0 assert #17688
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code asserts that floormod(input_dims[0], num_shards) can not be proven to be true, which has two problems: - It is unclear what it means to prove floormod(..). Prove that floormod's return value is truthy, i.e. non-zero? - It always checks the 0th dimension of the input shape, but the dimension index to be sharded is given by the "axis" parameter. This commit fixes both of the above.
Member
MasterJH5574
approved these changes
Feb 28, 2025
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Thank you @oskar-inceptron!
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
The current code asserts that floormod(input_dims[0], num_shards) can not be proven to be true, which has two problems: - It is unclear what it means to prove floormod(..). Prove that floormod's return value is truthy, i.e. non-zero? - It always checks the 0th dimension of the input shape, but the dimension index to be sharded is given by the "axis" parameter. This commit fixes both of the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code asserts that floormod(input_dims[0], num_shards) can not be proven to be true, which has two problems:
This commit fixes both of the above.