Skip to content

Fix relax.ccl.scatter_from_worker0 assert #17688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterJH5574 merged 1 commit into from
Feb 28, 2025
Merged

Fix relax.ccl.scatter_from_worker0 assert #17688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/relax/op/ccl/ccl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,12 @@ StructInfo InferStructInfoScatter(const Call& call, const BlockBuilder& ctx) {
auto input_shape = input_sinfo->GetShape();
CHECK(input_shape.defined()) << "input tensor of scatter_from_worker0 should have defined shape.";

if (analyzer->CanProve(floormod(input_shape.value()[0], PrimExpr(num_workers))) != 0) {
if (analyzer->CanProve(floormod(input_shape.value()[attrs->axis], PrimExpr(num_workers)) != 0)) {
ctx->ReportFatal(Diagnostic::Error(call)
<< "scatter_from_worker0 expects the size of axis 0 of input tensor to be "
"divisible by the "
"num_workers. However, the axis 0 of input tensor is "
<< input_shape.value() << " while num_workers is " << num_workers);
<< "scatter_from_worker0 expects the size of axis " << attrs->axis
<< " of input tensor to be divisible by the num_workers. However, axis "
<< attrs->axis << " of input tensor is " << input_shape.value()
<< " while num_workers is " << num_workers);
}

Array<PrimExpr> output_shape = input_shape.value();
Expand Down