Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dmlc-core, fix default ctors of NodeEntry #3017

Merged
merged 6 commits into from
Apr 17, 2019
Merged

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 13, 2019

MXNet uses nullptr to designate a node in which autograd is not enabled.

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@larroy
Copy link
Contributor Author

larroy commented Apr 15, 2019

@tqchen is CI working?

@tqchen
Copy link
Member

tqchen commented Apr 16, 2019

The CI is reporting lint error that you will need to fix http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3017/2/pipeline

@tqchen tqchen added the status: need update need update based on feedbacks label Apr 16, 2019
@tqchen
Copy link
Member

tqchen commented Apr 16, 2019

@larroy please act to fix the CI's lint report

@tqchen tqchen merged commit d5f7224 into apache:master Apr 17, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need update need update based on feedbacks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants