Update dmlc-core, fix default ctors of NodeEntry (apache#3017)

wweic · May 13, 2019 · 8cc9fa2 · 8cc9fa2
1 parent 4d64ff2
commit 8cc9fa2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/3rdparty/dmlc-core b/3rdparty/dmlc-core
diff --git a/nnvm/include/nnvm/node.h b/nnvm/include/nnvm/node.h
@@ -56,8 +56,18 @@ struct NodeEntry {
     version(version)
   {}
 
+  explicit NodeEntry(NodePtr node):
+    node(std::move(node)),
+    index(),
+    version()
+  {}
+
+  /**
+   * MXNet assumes that a node with a null ptr doesn't have a gradient attached. Don't change this
+   * constructor.
+   */
   NodeEntry():
-    node(),
+    node(nullptr),
     index(),
     version()
   {}