Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fix for PR#2972 (case of missing import) #3044

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Additional fix for PR#2972 (case of missing import) #3044

merged 1 commit into from
Apr 18, 2019

Conversation

cbalint13
Copy link
Contributor

It is an additional fix for #2972 as mentioned by @apivovarov .

@merrymercy ,

Can review confirm please ?

@apivovarov
Copy link
Contributor

I'm not sure we want to import relay if user decided to use nnvm.compiler.build.
Can we use string comparison here? e.g.

if F.__name__ == 'tvm.relay.op':

@cbalint13
Copy link
Contributor Author

I'm not sure we want to import relay if user decided to use nnvm.compiler.build.
Can we use string comparison here? e.g.

if F.__name__ == 'tvm.relay.op':

Did it. Ditto, in case of F == sym for consistency, idea is to remove import.

@cbalint13 cbalint13 closed this Apr 18, 2019
@cbalint13 cbalint13 reopened this Apr 18, 2019
@tqchen tqchen merged commit 2a7f754 into apache:master Apr 18, 2019
@cbalint13
Copy link
Contributor Author

@apivovarov , @tqchen

Thank you all !

larroy pushed a commit to larroy/tvm that referenced this pull request Apr 19, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants