[Doc][Relay] Add VM doc #3188
Merged
[Doc][Relay] Add VM doc #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
reviewed
May 13, 2019
|
Will give this a review soon |
weberlo
suggested changes
May 15, 2019
zhiics
reviewed
May 15, 2019
There was a problem hiding this comment.
I've left mostly grammar and style feedback. On a high level, I think this document does a good job of establishing the context for the Relay VM, but could stand to be more specific about what exactly the VM does to solve the problems that the interpreter and graph runtime have; I don't think that would require very large additions to the text.
Co-Authored-By: Steven S. Lyubomirsky <slyubomirsky@gmail.com> Co-Authored-By: 雾雨魔理沙 <lolisa@marisa.moe> Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> Co-Authored-By: Zhi <5145158+zhiics@users.noreply.github.com>
|
Thanks everyone! Addressed all comments. Please take another look. |
Co-Authored-By: 雾雨魔理沙 <lolisa@marisa.moe>
weberlo
suggested changes
May 17, 2019
wweic
commented
May 18, 2019
wweic
commented
May 18, 2019
Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com>
weberlo
suggested changes
May 18, 2019
Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com>
weberlo
approved these changes
May 19, 2019
yongwww
reviewed
May 20, 2019
Co-Authored-By: Yong Wu <55wuyong@163.com>
|
ping reviewers(@jroesch @tqchen @zhiics @icemelon9 @MarisaKirisame @yongwww @joshpoll @weberlo @slyubomirsky @junrushao1994 @nhynes), please take another look at this PR. thanks! |
MarisaKirisame
approved these changes
May 23, 2019
zhiics
approved these changes
May 23, 2019
yongwww
approved these changes
May 24, 2019
|
LGTM |
jroesch
approved these changes
May 27, 2019
wweic
added a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
* [Doc][Relay] Add VM doc * Add Apache header * Apply suggestions from code review Co-Authored-By: Steven S. Lyubomirsky <slyubomirsky@gmail.com> Co-Authored-By: 雾雨魔理沙 <lolisa@marisa.moe> Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> Co-Authored-By: Zhi <5145158+zhiics@users.noreply.github.com> * Junru's comment * More fix * More fix * More fix * last fix * Apply suggestions from code review Co-Authored-By: 雾雨魔理沙 <lolisa@marisa.moe> * Apply suggestions from code review Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> * Add code links * Remove unused bp * Update docs/dev/virtual_machine.rst Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> * Explain TODO * Yong's comment Co-Authored-By: Yong Wu <55wuyong@163.com> * Comment
wweic
added a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
* [Doc][Relay] Add VM doc * Add Apache header * Apply suggestions from code review Co-Authored-By: Steven S. Lyubomirsky <slyubomirsky@gmail.com> Co-Authored-By: 雾雨魔理沙 <lolisa@marisa.moe> Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> Co-Authored-By: Zhi <5145158+zhiics@users.noreply.github.com> * Junru's comment * More fix * More fix * More fix * last fix * Apply suggestions from code review Co-Authored-By: 雾雨魔理沙 <lolisa@marisa.moe> * Apply suggestions from code review Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> * Add code links * Remove unused bp * Update docs/dev/virtual_machine.rst Co-Authored-By: Logan Weber <36520469+weberlo@users.noreply.github.com> * Explain TODO * Yong's comment Co-Authored-By: Yong Wu <55wuyong@163.com> * Comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doc is a merge of #2915 and #2810.
cc: @jroesch @tqchen @zhiics @icemelon9 @MarisaKirisame @yongwww @joshpoll @weberlo @slyubomirsky @junrushao1994 @nhynes