Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc][Relay] Add VM doc #3188
[Doc][Relay] Add VM doc #3188
Changes from 2 commits
3041764
b03928b
da51c6a
c1846a8
b16a7a0
526f945
c03138d
97f7b7f
14a9d2e
fe22f6b
a4e6f2d
a744bb1
0e8cc0f
f56bb28
856448f
79429d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by "solid" here? Free from bugs and fast? I think the text should be specific about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "we must change how execution works" is too vague. I think the sentence should reflect that we have to have mechanisms in our compilation tailored to accommodate these features or something that is more clear about how we are changing the execution mechanisms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we such design discussion to be in the doc? It sounds like it would quickly become outdated (and docs don't tend to be updated that frequently). The same goes for the above remarks on serialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slyubomirsky good catch! I'll probably add a TODO section here since we haven't finalized on dynamic shape yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last sentence would be better left unsaid