Structural hash - Incorporating the Var hash into generating hash #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the BindVar function does not take Var type into account. This causes two same graph structures with different var shapes to have same hash. Structural hash is used for keeping track of which operators we have already compiled. Because of this, two operators with different shapes end up pointing to same compiled code. The failure is encountered at runtime, where the expected input shape asserts are not met.
|
Great catch, probably due to the type annotation field changing after the hashing code was written by me. LGTM. |
jroesch
approved these changes
May 31, 2019
jroesch
approved these changes
May 31, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
…hash (apache#3267) Currently, the BindVar function does not take Var type into account. This causes two same graph structures with different var shapes to have same hash. Structural hash is used for keeping track of which operators we have already compiled. Because of this, two operators with different shapes end up pointing to same compiled code. The failure is encountered at runtime, where the expected input shape asserts are not met.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
…hash (apache#3267) Currently, the BindVar function does not take Var type into account. This causes two same graph structures with different var shapes to have same hash. Structural hash is used for keeping track of which operators we have already compiled. Because of this, two operators with different shapes end up pointing to same compiled code. The failure is encountered at runtime, where the expected input shape asserts are not met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the BindVar function does not take Var type into account. This causes
two same graph structures with different var shapes to have same hash.
Structural hash is used for keeping track of which operators we have
already compiled. Because of this, two operators with different shapes end up
pointing to same compiled code. The failure is encountered at runtime, where the
expected input shape asserts are not met.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.