Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural hash - Incorporating the Var hash into generating hash #3267

Merged
merged 1 commit into from
May 31, 2019
Merged

Structural hash - Incorporating the Var hash into generating hash #3267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/relay/ir/hash.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,9 @@ class RelayHashHandler:
size_t BindVar(const NodeRef& var) {
size_t hash = std::hash<int>()(var_counter++);
CHECK_EQ(hash_map_.count(var), 0);
if (auto var_node = var.as<VarNode>()) {
hash = Combine(hash, TypeHash(var_node->type_annotation));
}
hash_map_[var] = hash;

const auto* ty_param = var.as<TypeVarNode>();
Expand Down
18 changes: 18 additions & 0 deletions tests/python/relay/test_pass_alpha_equal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,24 @@ def test_graph_equal():
# Check the difference in the text format.
assert not alpha_equal(z0, z3)

def test_hash_unequal():
x1 = relay.var("x1", shape=(10, 10), dtype="float32")
y1 = relay.var("y1", shape=(10, 10), dtype="float32")
func1 = relay.Function([x1, y1], relay.add(x1, y1))

# func2 is exactly same structure with same variables shapes and dtypes
x2 = relay.var("x2", shape=(10, 10), dtype="float32")
y2 = relay.var("y2", shape=(10, 10), dtype="float32")
func2 = relay.Function([x2, y2], relay.add(x2, y2))

assert ir_pass.structural_hash(func1) == ir_pass.structural_hash(func2)

# func3 is same as func1 but with different var shapes
x3 = relay.var("x3", shape=(20, 10), dtype="float32")
y3 = relay.var("y3", shape=(20, 10), dtype="float32")
func3 = relay.Function([x3, y3], relay.add(x3, y3))

assert not ir_pass.structural_hash(func1) == ir_pass.structural_hash(func3)

if __name__ == "__main__":
test_tensor_type_alpha_equal()
Expand All @@ -617,3 +634,4 @@ def test_graph_equal():
test_op_alpha_equal()
test_var_alpha_equal()
test_graph_equal()
test_hash_unequal()