Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TORCH] Implement avg_pool1d #7694

Merged
merged 4 commits into from
Mar 23, 2021
Merged

[TORCH] Implement avg_pool1d #7694

merged 4 commits into from
Mar 23, 2021

Conversation

cgerum
Copy link
Contributor

@cgerum cgerum commented Mar 18, 2021

This pull request implements avgpool1d support for the relay torch frontend.

@masahi
Copy link
Member

masahi commented Mar 18, 2021

Thanks, can you unify the avg_pool1d and 2d? They look identical.

@masahi masahi self-assigned this Mar 18, 2021
@cgerum
Copy link
Contributor Author

cgerum commented Mar 18, 2021

Thanks for the review, I hope this is what you had in mind.

@masahi
Copy link
Member

masahi commented Mar 18, 2021

Yes thanks, please fix the lint error

@cgerum
Copy link
Contributor Author

cgerum commented Mar 18, 2021

Lint error should be fixed, should I squash the commits?

@masahi
Copy link
Member

masahi commented Mar 18, 2021

No, we do squash merge anyway when the PR is merged.

@masahi
Copy link
Member

masahi commented Mar 22, 2021

@cgerum Can you try kick CI again? You can rebase and push.

@cgerum
Copy link
Contributor Author

cgerum commented Mar 22, 2021

The builder seems to have timed out. Should I just add a fake commit to retrigger the build?

Ah sorry, missed your last post. The branch has been rebased.

@masahi masahi merged commit f09f02e into apache:main Mar 23, 2021
@masahi
Copy link
Member

masahi commented Mar 23, 2021

Thanks @cgerum

@cgerum cgerum deleted the f/torch_avgpool1d branch March 23, 2021 09:23
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Mar 23, 2021
* [TORCH] Implement avg_pool1d

* [TORCH] Unify creation of avg_pooling operations

* [TORCH] Add tests for avg pooling with padding

* [TORCH] Make format checks happy with unified avg_pool
mehrdadh added a commit to mehrdadh/tvm that referenced this pull request Mar 23, 2021
mehrdadh added a commit to mehrdadh/tvm that referenced this pull request Mar 23, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* [TORCH] Implement avg_pool1d

* [TORCH] Unify creation of avg_pooling operations

* [TORCH] Add tests for avg pooling with padding

* [TORCH] Make format checks happy with unified avg_pool
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
* [TORCH] Implement avg_pool1d

* [TORCH] Unify creation of avg_pooling operations

* [TORCH] Add tests for avg pooling with padding

* [TORCH] Make format checks happy with unified avg_pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants