Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulkan][Runtime] Added dummy implementations for TVMStreamHandle operations #7969

Merged
merged 1 commit into from
May 4, 2021

Conversation

Lunderberg
Copy link
Contributor

rpc_runner_run interacts with stream handlers following PR #7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

…rations

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.
@Lunderberg
Copy link
Contributor Author

Potential reviewers: @masahi @tqchen

@masahi masahi self-assigned this May 3, 2021
Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've confirmed that auto scheduling on vulkan works again now.

@masahi masahi merged commit bfd8c67 into apache:main May 4, 2021
@masahi
Copy link
Member

masahi commented May 4, 2021

Thanks @Lunderberg @tqchen

umangyadav pushed a commit to umangyadav/tvm that referenced this pull request May 5, 2021
…rations (apache#7969)

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…rations (apache#7969)

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…rations (apache#7969)

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…rations (apache#7969)

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
@Lunderberg Lunderberg deleted the vulkan_tvmstreamhandle branch May 7, 2021 20:14
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
…rations (apache#7969)

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants