Skip to content

Commit

Permalink
[Vulkan][Runtime] Added dummy implementations for TVMStreamHandle ope…
Browse files Browse the repository at this point in the history
…rations (apache#7969)

rpc_runner_run interacts with stream handlers following PR apache#7819.
Vulkan currently executes adds everything into a single command buffer
per CPU thread, so there isn't a corresponding concept of streams.
Therefore, added no-op implementations for these DeviceAPI methods.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
  • Loading branch information
2 people authored and Trevor Morris committed May 6, 2021
1 parent 7a073c2 commit de23635
Showing 1 changed file with 15 additions and 12 deletions.
27 changes: 15 additions & 12 deletions src/runtime/vulkan/vulkan.cc
Original file line number Diff line number Diff line change
Expand Up @@ -373,29 +373,32 @@ class VulkanDeviceAPI final : public DeviceAPI {
}

public:
// Always use the default stream
TVMStreamHandle CreateStream(Device dev) {
LOG(FATAL) << "Not implemented";
return nullptr;
}

void FreeStream(Device dev, TVMStreamHandle stream) {
LOG(FATAL) << "Not implemented";
// Current vulkan implementation has one "stream" per CPU thread,
// with all commands writing into a single command buffer that is
// submitted on a call to StreamSync. Therefore, for now, these are
// mostly no-ops. If needed in the future, could have multiple
// command buffers to act as multiple streams.
TVMStreamHandle CreateStream(Device dev) final { return nullptr; }

void FreeStream(Device dev, TVMStreamHandle stream) final {
ICHECK_EQ(stream, static_cast<void*>(nullptr));
return;
}

void SyncStreamFromTo(Device dev, TVMStreamHandle event_src, TVMStreamHandle event_dst) {
LOG(FATAL) << "Not implemented";
// Syncing two streams is a nop, since there is only one stream.
void SyncStreamFromTo(Device dev, TVMStreamHandle event_src, TVMStreamHandle event_dst) final {
ICHECK_EQ(event_src, static_cast<void*>(nullptr));
ICHECK_EQ(event_dst, static_cast<void*>(nullptr));
return;
}

void StreamSync(Device dev, TVMStreamHandle stream) final {
ICHECK(stream == nullptr);
ICHECK_EQ(stream, static_cast<void*>(nullptr));
VulkanThreadEntry::ThreadLocal()->Stream(dev.device_id)->Synchronize();
}

void SetStream(Device dev, TVMStreamHandle stream) final {
LOG(FATAL) << "Not implemented";
ICHECK_EQ(stream, static_cast<void*>(nullptr));
return;
}

Expand Down

0 comments on commit de23635

Please sign in to comment.