Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan][Docs] Minor updates following Vulkan target query implementation #8151

Merged
merged 1 commit into from
Jun 2, 2021
Merged

[Vulkan][Docs] Minor updates following Vulkan target query implementation #8151

merged 1 commit into from
Jun 2, 2021

Conversation

Lunderberg
Copy link
Contributor

  • Better error messages, specifying which capability is needed.

  • Documentation section outlining the different target capabilities,
    which vulkan properties they correspond to, and which spir-v
    capabilities they are required by.

@Lunderberg
Copy link
Contributor Author

@masahi

@masahi
Copy link
Member

masahi commented May 27, 2021

please fix the build error.

@Lunderberg
Copy link
Contributor Author

Build error fixed. Thank you for the catch, and definitely time for me to set up a pre-commit hook, since I've forgotten both this and linting in the past.

@masahi masahi self-assigned this May 28, 2021
@Lunderberg
[Vulkan][Docs] Minor updates following Vulkan target query.
29744a3 
- Better error messages, specifying which capability is needed.

- Documentation section outlining the different target capabilities,
  which vulkan properties they correspond to, and which spir-v
  capabilities they are required by.
@Lunderberg
Copy link
Contributor Author

Rebased on main to start CI again, now that the CI fix #8160 is in.

@masahi masahi merged commit bb3e772 into apache:main Jun 2, 2021
@masahi
Copy link
Member

masahi commented Jun 2, 2021

Thanks @Lunderberg

@Lunderberg Lunderberg deleted the vulkan_target_query branch June 2, 2021 03:14
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
@Lunderberg
[Vulkan][Docs] Minor updates following Vulkan target query. (apache#8151
a12869e 
)

- Better error messages, specifying which capability is needed.

- Documentation section outlining the different target capabilities,
  which vulkan properties they correspond to, and which spir-v
  capabilities they are required by.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
@Lunderberg @trevor-m
[Vulkan][Docs] Minor updates following Vulkan target query. (apache#8151
e186df6 
)

- Better error messages, specifying which capability is needed.

- Documentation section outlining the different target capabilities,
  which vulkan properties they correspond to, and which spir-v
  capabilities they are required by.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees

@masahi masahi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lunderberg @masahi