Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] Update tensorflow/tflite/xgboost versions #8306

Merged
merged 2 commits into from
Jun 22, 2021
Merged

[Docker] Update tensorflow/tflite/xgboost versions #8306

merged 2 commits into from
Jun 22, 2021

Conversation

Lunderberg
Copy link
Contributor

@Lunderberg
[Docker] Updated tensorflow/tflite version to 2.4.2
b3f90ab 
Tensorflow update required following update to cuda 11.0.  Based on
https://www.tensorflow.org/install/source#gpu, the 2.4 branch of
tensorflow should be used with cuda 11.0.

- Removed pinned version of keras/h5py, no longer needed.

  tensorflow/tensorflow#44467 (comment)

- Updated tflite version to 2.4.2.  Also, tflite install script now
  reads the installed version of tensorflow, to keep the version
  matched in the future.
@Lunderberg
[Docker] Corrected version pinning of xgboost
89adbc0 
Previously, due to missing quotes, installed most recent version of
xgboost, piping the results to a file named '=1.1.0'.  Now, installs
xgboost at least at version 1.1.0.
@Lunderberg
Copy link
Contributor Author

@mbrookhart

@Lunderberg Lunderberg mentioned this pull request Jun 22, 2021
Closed
26 tasks
@mbrookhart mbrookhart merged commit 9f350d3 into apache:main Jun 22, 2021
@mbrookhart
Copy link
Contributor

Thanks @Lunderberg

@Lunderberg Lunderberg deleted the ci_image_versions branch June 23, 2021 03:25
@manupak manupak mentioned this pull request Jun 23, 2021
Merged
@manupak
Copy link
Contributor

manupak commented Jun 23, 2021 •
edited
Loading

Before merging changes to install scripts, would it be possible to check whether docker images that uses scripts can be built ?
In this case, ci_cpu will not build because tensorflow is installed after tflite is installed.

We have created a PR to fix this for now : #8312

cc : @leandron @areusch

@mbrookhart
Copy link
Contributor

This was my fault, I'm sorry. The Ubuntu repository for llvm was broken yesterday, so the docker build failed for unrelated reasons before I hit this, I should have waited

Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 23, 2021
@Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu
bb2333e 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.
@Lunderberg Lunderberg mentioned this pull request Jun 23, 2021
Merged
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 23, 2021
@Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu
dd0e0f0 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 24, 2021
@Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu
1cb28e9 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.
@manupak manupak mentioned this pull request Jun 25, 2021
Closed
mbrookhart pushed a commit that referenced this pull request Jun 25, 2021
@Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu (#8315)
70183ed 
Similar to #8312, the recently merged #8306 required tflite to be
installed after tf.  However, #8306 did not correct the ordering in
the dockerfiles.  After this and #8312, all dockerfiles should be up
to date with the correct ordering.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@Lunderberg @ylc
[Docker] Update tensorflow/tflite/xgboost versions (apache#8306)
88f84ec 
* [Docker] Updated tensorflow/tflite version to 2.4.2

Tensorflow update required following update to cuda 11.0.  Based on
https://www.tensorflow.org/install/source#gpu, the 2.4 branch of
tensorflow should be used with cuda 11.0.

- Removed pinned version of keras/h5py, no longer needed.

  tensorflow/tensorflow#44467 (comment)

- Updated tflite version to 2.4.2.  Also, tflite install script now
  reads the installed version of tensorflow, to keep the version
  matched in the future.

* [Docker] Corrected version pinning of xgboost

Previously, due to missing quotes, installed most recent version of
xgboost, piping the results to a file named '=1.1.0'.  Now, installs
xgboost at least at version 1.1.0.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@Lunderberg @ylc
[Docker] Fix ordering of tf and tflite installs in ci_qemu (apache#8315)
d15f641 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
@Lunderberg @ylc
[Docker] Update tensorflow/tflite/xgboost versions (apache#8306)
057c1f7 
* [Docker] Updated tensorflow/tflite version to 2.4.2

Tensorflow update required following update to cuda 11.0.  Based on
https://www.tensorflow.org/install/source#gpu, the 2.4 branch of
tensorflow should be used with cuda 11.0.

- Removed pinned version of keras/h5py, no longer needed.

  tensorflow/tensorflow#44467 (comment)

- Updated tflite version to 2.4.2.  Also, tflite install script now
  reads the installed version of tensorflow, to keep the version
  matched in the future.

* [Docker] Corrected version pinning of xgboost

Previously, due to missing quotes, installed most recent version of
xgboost, piping the results to a file named '=1.1.0'.  Now, installs
xgboost at least at version 1.1.0.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
@Lunderberg @ylc
[Docker] Fix ordering of tf and tflite installs in ci_qemu (apache#8315)
420e7c6 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart mbrookhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lunderberg @mbrookhart @manupak