Fix ordering of tf and tflite installs in ci_cpu #8312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for catching that. It looks like the |
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 23, 2021
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering.
26 tasks
|
CI failed on this one, due to a timeout. But CI doesn't really test anything related to the shell scripts on this PR. Based on that I'm gonna merge it, as I understand this was tested locally and is a necessary change. edit: we'll actually I can't. @manupa-arm can you poke CI once you have a moment, so that we can merge this? |
The recently merged 8306 PR introduced a depedency for tflite installation that tf must be installed first. However, that PR did not correct the ordering in ci_cpu which does not have that ordering. Change-Id: Ib82c2b33e4e123d4562682e9e97b21bfe23cc0ef
manupak
force-pushed
the
fix_tf_tflite_order_ci_cpu
branch
from
7ca8373 to
174ec44
Compare
|
Alright -- re-triggered it |
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 23, 2021
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 24, 2021
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
The recently merged 8306 PR introduced a depedency for tflite installation that tf must be installed first. However, that PR did not correct the ordering in ci_cpu which does not have that ordering. Change-Id: Ib82c2b33e4e123d4562682e9e97b21bfe23cc0ef
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
The recently merged 8306 PR introduced a depedency for tflite installation that tf must be installed first. However, that PR did not correct the ordering in ci_cpu which does not have that ordering. Change-Id: Ib82c2b33e4e123d4562682e9e97b21bfe23cc0ef
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently merged #8306 introduced a depedencyfor tflite installation that tf must be installed first.However, that PR did not correct the ordering in ci_cpu which does not have that ordering.
cc : @leandron @mbrookhart @Lunderberg