-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][Parser] Support slash in identifier. #8352
Conversation
Variables from tensorflow may contains '/' in name (x/y/z).
cc @areusch @tkonolige @comaniac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Relay][Parser] Support slash in identifier. Variables from tensorflow may contains '/' in name (x/y/z). * Check identifier name after parsing.
* [Relay][Parser] Support slash in identifier. Variables from tensorflow may contains '/' in name (x/y/z). * Check identifier name after parsing.
Variables from tensorflow may contains '/' in name (x/y/z).
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
@tqchen @jroesch please help to review this change, which found in tensorflow model
Thanks a lot :)
Regards,
Zack