[Relay][Parser] Support slash in identifier. (apache#8352)

* [Relay][Parser] Support slash in identifier. Variables from tensorflow may contains '/' in name (x/y/z). * Check identifier name after parsing.
ylc · Sep 29, 2021 · f89d478 · f89d478
1 parent 99839eb
commit f89d478
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/parser/tokenizer.h b/src/parser/tokenizer.h
@@ -62,7 +62,9 @@ bool IsNumeric(char c) {
          !IsWhitespace(c);
 }
 
-bool IsIdentLetter(char c) { return '_' == c || ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z'); }
+bool IsIdentLetter(char c) {
+  return '_' == c || c == '/' || ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z');
+}
 
 bool IsIdent(char c) { return IsIdentLetter(c) || IsDigit(c); }
 

diff --git a/tests/python/relay/test_ir_text_printer.py b/tests/python/relay/test_ir_text_printer.py
@@ -284,5 +284,14 @@ def test_optional_info():
     assert txt.count("/* ty=int32 */") == 3
 
 
+def test_slash_in_identifier():
+    x = relay.var("base/x")
+    y = relay.var("base/y")
+    z = x + y
+    txt = astext(z)
+    assert "base/x" in txt
+    assert "base/y" in txt
+
+
 if __name__ == "__main__":
     pytest.main([__file__])