Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][TensorRT] Fix dynamic batching when use_implicit_batch=False #8461

Merged

Conversation

trevor-m
Copy link
Contributor

Fixes error for subgraphs with dynamic batch size when use_implicit_batch=False. Added test case.

Also fixes deserialization of cached engine when batch size is not 1.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit d3db5d6 into apache:main Jul 17, 2021
@comaniac
Copy link
Contributor

Thanks @trevor-m

std::vector<int64_t> shape(data_entry_[eid]->shape,
data_entry_[eid]->shape + data_entry_[eid]->ndim);
auto dims = VectorToTrtDims(shape);
ICHECK(context->setBindingDimensions(binding_index, dims));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setBindingDimensions is not available in JP 4.2 TRT 5.0.6

error: ‘class nvinfer1::IExecutionContext’ has no member named ‘setBindingDimensions’

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants