[TVMC] Split common tvmc test file into more specific files #9206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead.
Mousius
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
|
@areusch I'll raise that as a separate PR, I have some questions based on others around the usage of these lines as I've never used the files in this way 😸 |
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
) The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 18, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 18, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 22, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 23, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 23, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 23, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Nov 24, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Dec 30, 2021
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
leandron
pushed a commit
that referenced
this pull request
Jan 4, 2022
This follows from #9206 and splits common.py into multiple smaller and more focussed files.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
) The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
) The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This follows from apache#9206 and splits common.py into multiple smaller and more focussed files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_tvmc_common.pyfile was becoming a bit of a mixed bag oftests and as we now want to extend the
Targetprocessing logic it madesense to split each out into its own file to make it clearer what each
does.
test_common.pyhas also been renamed before we start using it for all thetests instead.