Fixed some warnings about lambda's closures that are bigger than necessary #9481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecessary, and some missing parenthesis around an assignment in a conditional (LLVM fears a mistake where one wanted to use the equality test ==)
FranckQC
requested review from
anijain2305,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
…er 100 characters
comaniac
approved these changes
Nov 10, 2021
Hi @Mousius |
|
All the tests passed and it is now ready for being merged :) |
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Nov 12, 2021
* main: (119 commits) [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336) Fix repository URL in ubuntu_install_rocm.sh (apache#9425) Add LLVM-13 installation to Docker setup (apache#9498) [Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499) Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442) [COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488) Add default for split op (apache#9489) [HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486) Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481) [Support] Add libinfo into the runtime build (apache#9310) Change Call with TIRCallAttrs to call_lowered op (apache#9312) [ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477) [CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480) [MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335) [microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470) Better host handling in CompilationConfig & debug printing (apache#9460) [AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271) [TIR] Add type hint for TIR (apache#9432) [TVMC] Add test for quantized pytorch model (apache#9467) [CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397) ...
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…ssary (apache#9481) * Fixed some warnings, including lambdas closure that are bigger than necessary, and some missing parenthesis around an assignment in a conditional (LLVM fears a mistake where one wanted to use the equality test ==) * Fixed formatting as two lines can now be merged while still being under 100 characters
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…ssary (apache#9481) * Fixed some warnings, including lambdas closure that are bigger than necessary, and some missing parenthesis around an assignment in a conditional (LLVM fears a mistake where one wanted to use the equality test ==) * Fixed formatting as two lines can now be merged while still being under 100 characters
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…ssary (apache#9481) * Fixed some warnings, including lambdas closure that are bigger than necessary, and some missing parenthesis around an assignment in a conditional (LLVM fears a mistake where one wanted to use the equality test ==) * Fixed formatting as two lines can now be merged while still being under 100 characters
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
…ssary (apache#9481) * Fixed some warnings, including lambdas closure that are bigger than necessary, and some missing parenthesis around an assignment in a conditional (LLVM fears a mistake where one wanted to use the equality test ==) * Fixed formatting as two lines can now be merged while still being under 100 characters
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ssary (apache#9481) * Fixed some warnings, including lambdas closure that are bigger than necessary, and some missing parenthesis around an assignment in a conditional (LLVM fears a mistake where one wanted to use the equality test ==) * Fixed formatting as two lines can now be merged while still being under 100 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Just a couple of small changes to fix some warnings about some lambda's closures that are bigger than necessary as they capture variables that are not used.
Thanks!